This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Conversation
tracyboehrer
approved these changes
Mar 21, 2025
|
Thanks! When do you plan to release a new version on PyPi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2210
This pull request includes changes to the
remove_mention_textmethod inturn_context.pyand adds a new test case intest_turn_context.pyto ensure the method works correctly with custom mentions.Improvements to
remove_mention_textmethod:libraries/botbuilder-core/botbuilder/core/turn_context.py: Modified theremove_mention_textmethod to handle cases where the mention text is not directly available by using either thetextornameproperty fromadditional_properties.Additions to test cases:
libraries/botbuilder-core/tests/test_turn_context.py: Added a new test casetest_should_remove_custom_mention_from_activityto verify that theremove_mention_textmethod correctly removes custom mentions from the activity text.